Introduction of the mail:password analyzer. #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fix #82 Also: * Edition of the mail analyzer in order to share its pattern.
Pull Request Test Coverage Report for Build 121
💛 - Coveralls |
|
If you ask yourself why there is a syntax issue, it's probably because of my usage of Black, The uncompromising Python code formatter. Feel free to fix yourself. |
d-Rickyy-b
approved these changes
Oct 3, 2019
d-Rickyy-b
requested changes
Oct 3, 2019
| from pastepwn.analyzers.mailpasswordanalyzer import MailPasswordAnalyzer | ||
|
|
||
|
|
||
| class TestDBConnAnalyzer(unittest.TestCase): |
| import unittest | ||
| from unittest import mock | ||
|
|
||
| from pastepwn.analyzers.mailpasswordanalyzer import MailPasswordAnalyzer |
There was a problem hiding this comment.
It should be possible to do from pastepwn.analyzers import MailPasswordAnalyzer if you add the analyzer to the package init file
d-Rickyy-b
reviewed
Oct 3, 2019
| for positive in positives: | ||
| self.paste.body = positive | ||
| self.assertTrue( | ||
| self.analyzer.match(self.paste), f"{positive} do not match." |
There was a problem hiding this comment.
And as you stated in your comment, this somehow fails on Python 3.5 and earlier (see Travis). Maybe you can change it so that it does work with python 3.4 at least.
"{0} do not match.".format(positive) should work.
d-Rickyy-b
approved these changes
Oct 3, 2019
d-Rickyy-b
reviewed
Oct 3, 2019
| from .pastebinurlanalyzer import PastebinURLAnalyzer | ||
| from .privatekeyanalyzer import PrivateKeyAnalyzer | ||
| from .regexanalyzer import RegexAnalyzer |
There was a problem hiding this comment.
The sorting could lead to circular imports but I will check that myself before merging - no worries :)
d-Rickyy-b
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix #82
Also:
It was fun to write this #hacktoberfest solution. I hope you don't mind my edits.
Cheers,
Nissar