-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add order_class to the parsed order response. #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Thanks! Will merge after the markets open next.
Actually, nevermind; I merged it now. |
Thank you! What is the typical process for releasing the crate and how long does that take? I was hoping to use this change from apcacli to print the order type in the CLI output. No rush, just curious. |
There is no fixed timeline. Once the subjective measure of "sufficient changes to justify a release" has been reached it will happen. The barrier for patch releases (compatibility preserving) is typically much lower. Right now this is the only change we have for the next release. What's worse, this change is compatibility breaking. We can accelerate if there is a need, though. It's just a hassle for everyone if every commit were to create a new minor release that requires a bump in downstream code. |
Nope, no need to accelerate anything. And thank you for taking the time to explain. I have both branches locally and can use my versions for development and testing. When I see the new version, I'll send another pull request for apcacli. In the meantime, are there any issues you want help with on apca? |
Some ideas that I have on my TODO list are the following:
Since you were also looking into
Some of them may be significantly more involved than others; I've ordered them roughly by increasing anticipated complexity. Some are mostly investigative at this point and further work will depend on the outcome of the investigation. Happy to provide more context if you feel that something piques your interest, in which case I'd suggest you open a quick issue to discuss some more. |
This is extremely helpful. I will work on these with you. Thanks! |
Hm, only noticing now that this member should have been called |
https://alpaca.markets/docs/api-references/trading-api/orders/