Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for container calculations #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Traksewt
Copy link

@Traksewt Traksewt commented Sep 3, 2015

Calculating the end location was checking all parents. It should stop when it reaches the given container.

The window.internalHeight was interfering with the container animation exit calculations.

A threshold is added to stop the animation going on for a long time when the difference is less than a pixel.

@Traksewt
Copy link
Author

adding package.json for webpack installation.

@Traksewt Traksewt mentioned this pull request Apr 12, 2016
@samsullivan
Copy link

Thanks! This was much better than the fix I came up with (which didn't take into account any potential offsets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants