Added regex logic to handle errors and warnings displayed on console #51

David-Maisonave · 2021-10-05T20:18:56Z

Added regex logic to handle errors and warnings displayed on console.

Handles jump-to file, line no, and inline position.
Handles console coloring for errors

Added regex logic to handle errors and warnings displayed on console. 1. Handles jump-to file, line no, and inline position. 2. Handles console coloring for errors

d0vgan · 2021-10-07T07:29:53Z

NppExec/src/WarningAnalyzer.cpp

@@ -422,6 +422,69 @@ bool CWarningAnalyzer::match( const TCHAR* str )
        postr4 = skip_tabspaces(postr4);
        m_nChar = _ttoi(postr4);
    }
+    else // *** START: New regex Warning/Error parser
+    {	 // *** All of the new regex Warning/Error parser is within this else block ***
+        std::wsmatch match;


let's use std::match_results<const TCHAR*> instead

good idea. done.

d0vgan · 2021-10-07T07:30:25Z

NppExec/src/WarningAnalyzer.cpp

+    else // *** START: New regex Warning/Error parser
+    {	 // *** All of the new regex Warning/Error parser is within this else block ***
+        std::wsmatch match;
+        const std::wstring HeyStack = str;


Let's use std::basic_string<TCHAR> instead.
This applies to all the further occurrences of std::wstring.

good idea. done.

d0vgan · 2021-10-07T07:35:11Z

NppExec/src/WarningAnalyzer.cpp

+        static std::map<int,int> ErrPositionIndicator;
+        static std::wstring PreviousFileName;
+        static int PreviousLineNo = 0;
+        std::wregex std_Needle = std::wregex( L"(?:(([a-zA-Z]:[\\\\/]|\\.)[^.]*\\.[^:\"\\(\\s]{1,8})|(^\\w[^\\s:\\\\/]*\\.\\w{1,8}))(?=[\\s:(\",oline]{1,9}[0-9]+)" ); // Regex to find file name


The method CWarningAnalyzer::match is called for every line that is printed to NppExec's Console, so it may be too expensive to create the same instance of std_Needle again and again. Let's rather make the std_Needle to be a member variable that is created just once.

good idea. done.

d0vgan · 2021-10-07T07:37:13Z

NppExec/src/WarningAnalyzer.cpp

+            wcscpy_s( m_FileName, sizeof( m_FileName )/sizeof( m_FileName[0]), filename.c_str() );
+            m_nLastFoundIndex = 0;
+            *m_Filter = TFilter();
+            std_Needle = std::wregex( L"(?:^[^0-9a-zA-Z_]+|.*line )([0-9]+).*" );// Regex to find file number with file name preceeding it


Let's rather make it an additional member variable that is created just once.

good idea. done.

d0vgan · 2021-10-07T07:38:22Z

NppExec/src/WarningAnalyzer.cpp

+                *(COLORREF*)(&m_Filter->Effect.Red) = COLOR_CON_TEXTERR; //Only color if found file name and line number
+                m_nLine = std::stoi( strLineNo.c_str() );
+                PreviousLineNo = m_nLine;
+                std_Needle = std::wregex( L".*[^a-zA-Z](?:[0-9][,:]\\s*|[0-9] char[,:])([0-9]+).*" ); // Regex to find nChar with file number preceeding it


Let's rather make it an additional member variable that is created just once.

good idea. done.

d0vgan · 2021-10-07T07:40:09Z

NppExec/src/WarningAnalyzer.cpp

+                else
+                {
+                    Suffix = match.suffix();
+                    std_Needle = std::wregex( L"\\s+[\\x5E~]" ); // Regex to find error possition indicator


Let's rather make it an additional member variable that is created just once.

good idea. done.

d0vgan · 2021-10-07T07:41:54Z

NppExec/src/WarningAnalyzer.cpp

+        }
+        else
+        {
+            std_Needle = std::wregex( L"^[\\.\\s]+[\\x5E~]" ); // Regex to find error possition indicator starting at the begging of a line


Let's rather make it an additional member variable that is created just once.

good idea. done.

d0vgan · 2021-10-07T07:54:48Z

NppExec/src/WarningAnalyzer.cpp

+            std::wstring strLineNo = std::regex_replace( Suffix, std_Needle, L"$1" ); // Replace to get file number only
+            if ( strLineNo.size() && isdigit( strLineNo[0] ) )
+            {
+                *(COLORREF*)(&m_Filter->Effect.Red) = COLOR_CON_TEXTERR; //Only color if found file name and line number


Looks somewhat unsafe, no? (I mean, we assume that there is an implicit unsigned char dummy right after unsigned char Blue within the TEffect structure to match the sizeof(COLORREF) and that these members are aligned by exactly 1 byte.). I'd prefer explicit setting of the Effect.Red, Effect.Green and Effect.Blue members.

I changed TEffect so that the three unsigned char variables are in a union with COLORREF variable (rgb). And I changed line 449 to the following:
m_Filter->Effect.rgb = COLOR_CON_TEXTERR;
That allows RGB macro to safely be used to set the colors. It's common programming practice on multiple languages to use RGB for color settings. And it's easy to find RGB color charts online.
https://www.ginifab.com/feeds/pms/color_picker_from_image.php
https://www.w3schools.com/colors/colors_converter.asp
http://www.zonums.com/online/color_converter/

d0vgan · 2021-10-07T07:58:23Z

NppExec/src/WarningAnalyzer.cpp

+            m_Filter->Effect.Bold = true;
+            m_Filter->Effect.Enable = true;
+            std::transform( filename.begin(), filename.end(), filename.begin(), ::tolower );
+            if ( filename.size() > 4 && filename.substr( filename.size() - 4 ) == L".exe" )


We may use lstrcmp to compare the existing last 4 characters of filename with _T(".exe") instead of using a temporary string produced by substr.

Good idea. When I went to make the changed, I realized I could just use lstrcmpi, and removed the previous line that changed it to lowercase.

d0vgan · 2021-10-07T08:04:58Z

NppExec/src/WarningAnalyzer.cpp

+            std_Needle = std::wregex( L"^[\\.\\s]+[\\x5E~]" ); // Regex to find error possition indicator starting at the begging of a line
+            if ( std::regex_search( HeyStack, match, std_Needle ) ) // Find error possition indicator
+            {
+                std::wstring ErrorPositionIndicator = match[0].str().size() > 2 && match[0].str().substr( 0, 3 ) == L"..." ? match[0].str().substr( 3 ) : match[0].str();


let's use
match[0].str().compare( 0, 3, _T("...") ) == 0
instead of
match[0].str().substr( 0, 3 ) == L"..."

Done. Although the difference is compiled away.

d0vgan · 2021-10-07T08:10:40Z

DefaultScripts/DebugAnyThing.NppExec

+	// ToDo: ********** If needed, append your new *[Run Handler]* HERE by adding another "else if" block to handle your file extension type. **********
+	// --------------------------------------------------------------------------------------
+	// Example #1 *[Run Handler]* for files with extension .foo, where MyFooScriptRunner.exe is an executable that knows what to do with (.foo) files.
+	else if $(ext) == .foo


This else if is not a part of a comment, so let's unindent it (remove the leading spaces) to avoid visual confusion of its scope.
This comment applies to all the other indented else if as well.

I'm still working on DebugAnyThing.NppExec.
Is there a way to select the files that should be included in the pull request?
The only files I intended to include was WarningAnalyzer.cpp, WarningAnalyzer.h, NppExecEngine.cpp, and DlgConsole.cpp.

WarningAnalyzer.cpp and WarningAnalyzer.h are the only ones with the regex code changes.

You may create a separate git branch for each independent change (e.g. one branch for the regex to handle errors, another branch for the NppExec script, etc.).
In your case, when everything is already in your "master" branch, probably the best way to separate different things is to:

cancel this pull request

manually copy your changed files to some temporary folder

reset all your changes in the "master" branch

create a new branch e.g. "feature/regex-warn-analyzer", checkout that new branch and manually copy the related changed files from your temporary folder (created in the step 1 above) to this new branch

create a new pull request against this new branch (it will replace the previously cancelled pull request)

checkout the "master" branch and create a new branch e.g. "feature/nppexec-scripts", checkout that new branch and manually copy the related changed files from your temporary folder to this new branch. Thus you'll have two independent branches with independent changes

when all the changes in the "feature/nppexec-scripts" branch are ready, create a pull request against this branch.

d0vgan · 2021-10-07T08:14:26Z

NppExec/NppExec_VC2017.vcxproj

@@ -188,6 +188,9 @@
      <ImportLibrary>$(OutDir)NppExec.lib</ImportLibrary>
      <AdditionalDependencies>shlwapi.lib;%(AdditionalDependencies)</AdditionalDependencies>
    </Link>
+    <PostBuildEvent>
+      <Command>copy "$(TargetPath)" "%APPDATA%\Notepad++\plugins\$(TargetName)"</Command>


Personally I use a portable version of Notepad++, thus there is no "%APPDATA%\Notepad++\plugins$(TargetName)" on my machine.
Also, there is no "%APPDATA%\Notepad++\plugins$(TargetName)" on a generic build machine where NppExec's sources are built.
Maybe let's customize this command to copy only in case of the folder "%APPDATA%\Notepad++\plugins" exists?

I actually didn't intend to merge NppExec_VC2017.vcxproj change with the master. I pushed it on my fork so I wouldn't loose the change.
I did add the if exist before the copy command, so if you want, you could add it to the master.

d0vgan · 2021-10-09T18:09:34Z

NppExec/src/WarningAnalyzer.cpp

+        {
+            if ( std::regex_search( HeyStack, match, m_rgxFindErrPosIndicatorAtStartOfLine ) ) // Find error possition indicator
+            {
+                tstring ErrorPositionIndicator = match[0].str().size() > 2 && match[0].str().compare( 0, 3, _T("...") ) == 0 ? match[0].str().substr( 3 ) : match[0].str();


Let's enclose the condition in parentheses? Frankly, I needed several attempts to understand how this long construction with && and ? works :)

d0vgan · 2021-10-09T18:14:30Z

NppExec/src/WarningAnalyzer.cpp

+                PreviousFileName = filename;
+                ErrPositionIndicator.clear();
+            }
+            wcscpy_s( m_FileName, sizeof( m_FileName )/sizeof( m_FileName[0]), filename.c_str() );


Let's use lstrcpy instead of wcscpy_s.

David-Maisonave · 2021-10-10T02:40:16Z

Closing this pull request because it included more files then intended.
Moved the desired changes to #55

Added regex logic to handle errors and warnings displayed on console

8e8cacd

Added regex logic to handle errors and warnings displayed on console. 1. Handles jump-to file, line no, and inline position. 2. Handles console coloring for errors

David-Maisonave mentioned this pull request Oct 6, 2021

[Pull Request] Regex logic to handle errors and warnings displayed on console #53

Closed

David-Maisonave added 7 commits October 6, 2021 15:27

Fix compiler warning

5370ec1

Improved regex

29dc342

Fixed tabify

7aff3b9

Update .gitignore

fe4da73

Update .gitignore

dfc8aef

Added Default Script folder and first default script file

feb6c85

Renamed first script and added debug script

4ac1512

d0vgan reviewed Oct 7, 2021

View reviewed changes

David-Maisonave added 9 commits October 8, 2021 17:30

Fixes per code review

8e9a0ab

NppExec scripts and testing source files

370f42b

Added RGB capability to TEffect

64761f2

Changed the DWORD to COLORREF

197bea7

Additional code review change

87ea826

Had to revert a change.

3484548

Update WarningAnalyzer.cpp

560d204

Update WarningAnalyzer.cpp

cf6dc81

Update NppExec_VC2017.vcxproj

090485b

d0vgan reviewed Oct 9, 2021

View reviewed changes

David-Maisonave added 2 commits October 9, 2021 21:23

Adding last changes before reset

bcf16d1

Reset to original master

4caeb8f

David-Maisonave closed this Oct 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added regex logic to handle errors and warnings displayed on console #51

Added regex logic to handle errors and warnings displayed on console #51

David-Maisonave commented Oct 5, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021 •

edited

David-Maisonave Oct 8, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021 •

edited

David-Maisonave Oct 8, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 8, 2021

d0vgan Oct 9, 2021

d0vgan Oct 7, 2021

David-Maisonave Oct 9, 2021

d0vgan Oct 9, 2021

d0vgan Oct 9, 2021

David-Maisonave commented Oct 10, 2021

Added regex logic to handle errors and warnings displayed on console #51

Added regex logic to handle errors and warnings displayed on console #51

Conversation

David-Maisonave commented Oct 5, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

d0vgan Oct 7, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

d0vgan Oct 7, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

David-Maisonave commented Oct 10, 2021

d0vgan Oct 7, 2021 •

edited

d0vgan Oct 7, 2021 •

edited