Type maps #3
Open
Type maps #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hChildren conflicts
It is possible to generate IDs during AST processing by performing a deep search for the last ID in all the original source units; however, this breaks the current tests for the copy method in ASTNodeFactory, which expect hard-coded IDs for specific nodes. Since they are created *after* all of the original source units are processed, and those all have independent contexts, this does not seem like an actual issue or breaking change for consumers. Until the tests are updated or a better mechanism is determined, the current workaround is to offset yul AST nodes by 100000.
Tests use specific string constants to test the formatting behavior. This uses the .raw original AST node to print child yul ast nodes. This still breaks on the copy test because some fields in InlineAssembly print different types now that YulBlock replaced YulNode and .yul is part of children.
…rsions as deprecated
Simplifies checking if an object is an instance of multiple classes
… type for identifiable nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.