Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👾 BUG | 如果停留在首页刷新的话，之前打开的标签都会关掉（本地运行才会，线上demo没有问题） #201

Closed
kakaxiu opened this issue Jul 14, 2019 · 4 comments
Closed

👾 BUG | 如果停留在首页刷新的话，之前打开的标签都会关掉（本地运行才会，线上demo没有问题） #201

kakaxiu opened this issue Jul 14, 2019 · 4 comments
Labels
released

Comments

@kakaxiu
Copy link

kakaxiu commented Jul 14, 2019

d2在本地跑发现一个小问题， 如果停留在首页刷新的话， 之前打开的标签都会关掉
研究了一番发现是store d2admin/page/open 逻辑好像有点问题， 默认取state.opened: setting.page.opened来判断当前页面有没有打开过
如果是首页就判断打开过，然后加载setting.page.opened的内容（只有首页）
如果不是首页反而判断没有打开过，加载缓存数据（缓存加当前页面）

但是官方线上demo不会出现这种情况， 求解~
@CuteFakin
Copy link

同样遇到这个bug了

@FairyEver
Copy link
Member

我抽时间看一下（大概明天），大家先继续手里的其它工作

@FairyEver
Copy link
Member

我测试发现是在本地运行的时候，page 模块中的 open 先于 openedLoad 执行导致，已经在 90ab115 更新解决方法

@FairyEver FairyEver mentioned this issue Jul 16, 2019
Closed
@cosoc cosoc mentioned this issue Aug 17, 2019
Closed
Aysnine pushed a commit that referenced this issue Dec 13, 2019
@FairyEver
fixed #201
a0bc7d8 
Former-commit-id: 90ab115
Aysnine pushed a commit that referenced this issue Dec 13, 2019
@FairyEver
fixed #201
ba18356 
Former-commit-id: c11713ccf82883db30b6d80e524d387a131c7ef4 [formerly 90ab115]
Former-commit-id: a0bc7d8
Aysnine pushed a commit that referenced this issue Dec 13, 2019
@FairyEver
fixed #201
117c539 
Former-commit-id: c11713ccf82883db30b6d80e524d387a131c7ef4 [formerly c11713ccf82883db30b6d80e524d387a131c7ef4 [formerly 90ab115]]
Former-commit-id: a0bc7d8
Former-commit-id: ba18356
Aysnine pushed a commit that referenced this issue Dec 13, 2019
@FairyEver
fixed #201
c849626 
Former-commit-id: c3c9c266fb51909a82a2af7177d5ae58ee69fd23 [formerly c3c9c266fb51909a82a2af7177d5ae58ee69fd23 [formerly c3c9c266fb51909a82a2af7177d5ae58ee69fd23 [formerly c3c9c266fb51909a82a2af7177d5ae58ee69fd23 [formerly 90ab115]]]]
Former-commit-id: a0bc7d8
Former-commit-id: ba18356
Former-commit-id: ed585555dc6768164db843649cb29c7939b92c81 [formerly 117c539]
Former-commit-id: d7b1f345b1fd7ca6672e1959128cd6e8cc300257
Aysnine pushed a commit that referenced this issue Dec 13, 2019
@FairyEver
fixed #201
b9293a4 
Former-commit-id: 7670649fb17b56af919c869f151c402c759d06e3 [formerly 7670649fb17b56af919c869f151c402c759d06e3 [formerly 7670649fb17b56af919c869f151c402c759d06e3 [formerly 7670649fb17b56af919c869f151c402c759d06e3 [formerly 8aa862c [formerly 26f5245cdaaf64c6f6eb205b728149f4a5bc4c9d]]]]]
Former-commit-id: a0bc7d8
Former-commit-id: ba18356
Former-commit-id: ed585555dc6768164db843649cb29c7939b92c81 [formerly 4b45f853c1356db04b9e061dac3f681d2a96a570]
Former-commit-id: d7b1f345b1fd7ca6672e1959128cd6e8cc300257
Former-commit-id: a670f7e5f832294063a613c83bc0bcf0eeab7d91
@FairyEver
Copy link
Member

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kakaxiu @FairyEver @CuteFakin