Make all listeners non-passive #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listeners are *non*-passive by default. But it is possible to use something like https://github.com/zzarcon/default-passive-events to make listeners passive by default. In this case one must be explicit with where one wants *non*-passive listeners. Fixes: #51
|
Edit: Oops, misread the change. Sorry. |
|
(Ahem, take two.) Thank you for the pull request! As you say, event listeners are not passive by default. Yes, we could explicitly declare that our listeners are not passive, but this is unnecessary as that is the default behavior of eventTarget.addEventListener. The default-passive-events library deviates from the standard by changing the default to passive. D3 is coded to web standards and unfortunately it is not feasible for me to accommodate libraries that intentionally deviate from standard behavior. Sorry! |
|
Good to know. Thanks for the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listeners are non-passive by default. But it is possible to use something like https://github.com/zzarcon/default-passive-events to make listeners passive by default. In this case one must be explicit with where one wants non-passive listeners.
Fixes: #51