Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedral projections. #47

Closed
mbostock opened this issue Jul 5, 2016 · 4 comments
Closed

Polyhedral projections. #47

mbostock opened this issue Jul 5, 2016 · 4 comments

Comments

@mbostock
Copy link
Member

mbostock commented Jul 5, 2016

It would be nice to update these to d3-geo 1.1+ and release them as a D3 module:

https://github.com/d3/d3-plugins/tree/master/geo/polyhedron
@Fil
Copy link
Member

Fil commented Jul 5, 2016 •
edited
Loading

related examples:
http://bl.ocks.org/mbostock/4458680 (gnomonic butterfly)
http://bl.ocks.org/mbostock/4458497 (waterman butterfly)
d3/d3-geo-projection@48bb952

research projects:
d3/d3-geo-projection#6 (cahillKeyes)
d3/d3-geo-projection#25 (dymaxion)

@Fil
Copy link
Member

Fil commented Aug 12, 2016

I did some tests here http://bl.ocks.org/Fil/b369b7fea5daa486a3ec8d6829d6b0b9 and there doesn't seem to be any problem. But I'm not sure we need yet another module: can't we simply package them together with https://github.com/d3/d3-geo-projection ?

Fil added a commit to Fil/d3-geo-projection that referenced this issue Aug 12, 2016
@Fil
port polyhedronButterFly and polyhedronWaterman to v4
c3460db 
missing:
- [ ] inverse projections
- [ ] Waterman scale
- [ ] Collignon

Ref: d3/d3-geo#47
@Fil Fil mentioned this issue Aug 12, 2016
Merged
@Fil
Copy link
Member

Fil commented Aug 13, 2016

done

@mbostock
Copy link
Member Author

This is great! Sorry I haven’t had a chance to review your pull request. I’m going to close this issue since and track this work with your pull request, d3/d3-geo-projection#69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fil @mbostock