Clamp Mercator clip extent. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the projection from breaking if the clip extent is specified outside ±180° longitude. However, this implementation leaks the clamped clip extent; it can be seen on retrieval. This should be fixed.
Also, we must recompute the intersection if the scale or translate changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mercator projection is only defined on x in [tx - k × π, tx + k × π] where tx is the x-translate (projection.translate) and k is the scale (projection.scale). Thus setting a manual clip extent outside these bounds can break the projection; see #55 (comment).
If a clip extent is specified, this clip extent is now intersected with the defined extent of the Mercator projection on x. Note that it is not clamped on y, as the Mercator projection is defined to the poles at infinity.