This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
sankey: fix nodesByBreadth to have proper ordering #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3.nest().key() converts all keys into strings. d3.ascending does not coerce strings into numbers for comparison -- do it ourselves. This improves relaxation efficiency. Before, it could traverse levels in the wrong orders, taking longer to propagate values up.
fbreitwieser
added a commit
to fbreitwieser/d3-sankey
that referenced
this pull request
Oct 19, 2016
- has several modifications from networkD3 sankey.js - included fixes and features from unmerged pull requests: - d3/d3-plugins#124: Fix nodesByBreadth to have proper ordering - - d3/d3-plugins#120: Added 'l-bezier' link type - d3/d3-plugins#74: Sort sankey target links by descending slope - d3#4: Add horizontal alignment option to Sankey layout - added option numberFormat, default being ",.5g" (see , fixes christophergandrud/networkD3#147) - added option NodePosX, fixes christophergandrud/networkD3#108 - added option to force node ordering to be alphabetical along a path (only works well with trees with one parent for each node, but might fix christophergandrud/networkD3#153)
fbreitwieser
added a commit
to fbreitwieser/sankeyD3
that referenced
this pull request
Oct 19, 2016
Changelog: - ported to D3 v4 - based on https://github.com/d3/d3-sankey - added several modifications from networkD3 sankey.js - included fixes and features from unmerged pull requests: - d3/d3-plugins#124: Fix nodesByBreadth to have proper ordering - d3/d3-plugins#120: Added 'l-bezier' link type - d3/d3-plugins#74: Sort sankey target links by descending slope - d3/d3-sankey#4: Add horizontal alignment option to Sankey layout - added option numberFormat, default being ",.5g" (see , fixesristophergandrud/networkD3#147) - added option NodePosX, fixes christophergandrud/networkD3#108 - added option to force node ordering to be alphabetical along a path (only works well with trees with one parent for each node, but might fix christophergandrud/networkD3#153)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d3.nest().key() converts all keys into strings. d3.ascending does not coerce strings into numbers for comparison -- do it ourselves.
This improves relaxation efficiency. Before, it could traverse levels in the wrong order, taking longer to propagate values up.