Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for unlimited outer padding #102

Closed
hhrogersii opened this issue Apr 27, 2017 · 0 comments
Closed

Allow for unlimited outer padding #102

hhrogersii opened this issue Apr 27, 2017 · 0 comments

Comments

@hhrogersii
Copy link

In D3v3 the d3.scale.ordinal().rangeBands(interval[, padding[, outerPadding]]) accepted an outerPadding value greater than 1. I was using this to prevent the bandwidth on a bar chart from exceeding a defined max bar width. In D3v4 the d3.scaleBand().paddingOuter() will clip any value greater than 1. While this makes sense for most bar chart layouts, for charts with one or two bars, the bars can be exceedingly wide. Also, as a general drawing language, it would be helpful to allow unlimited outer margins.
outer-padding
Pull request with one test change: #101

mbostock added a commit that referenced this issue Jan 26, 2019
Also clarify the documentation for outer padding.

Fixes #101.
Fixes #102.
Fixes #132.
@mbostock mbostock mentioned this issue Jan 26, 2019
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant