Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selection.transition(transition) should error if the transition isn’t found. #59

Closed
mbostock opened this issue Oct 8, 2016 · 1 comment · Fixed by #94
Closed

selection.transition(transition) should error if the transition isn’t found. #59

mbostock opened this issue Oct 8, 2016 · 1 comment · Fixed by #94

Comments

@mbostock
Copy link
Member

mbostock commented Oct 8, 2016

See #45 (comment).
mbostock added a commit that referenced this issue Oct 8, 2016
@mbostock
Update README. Related #59.
3d5e0df
@mbostock
Copy link
Member Author

mbostock commented Jul 7, 2017

Changing this behavior should probably be a breaking change (d3-transition@2, d3@5).

mbostock added a commit that referenced this issue Jul 30, 2019
@mbostock
Fix #59.
6d3591d
This was referenced Nov 11, 2019
Closed
Merged
@Fil Fil closed this as completed in #94 Aug 23, 2020
@EndilWayfare EndilWayfare mentioned this issue Jan 20, 2021
Open
magjac added a commit to magjac/d3-graphviz that referenced this issue Mar 30, 2021
@magjac
Fix incorrect transition test exposed by d3-transition fix
43858c1 
The original test was incorrect since it tried to reuse a transition
that had expired. This went unnoticed until
d3/d3-transition#59 was fixed.
magjac added a commit to magjac/d3-graphviz that referenced this issue Mar 30, 2021
@magjac
Fix incorrect zoom test exposed by d3-transition fix
60b3672 
The original test was incorrect since it tried to reuse a transition
that had expired. This went unnoticed until
d3/d3-transition#59 was fixed.
magjac added a commit to magjac/d3-graphviz that referenced this issue Apr 2, 2021
@magjac
Fix incorrect transition test exposed by d3-transition fix
7da4429 
The original test was incorrect since it tried to reuse a transition
that had expired. This went unnoticed until
d3/d3-transition#59 was fixed.
magjac added a commit to magjac/d3-graphviz that referenced this issue Apr 2, 2021
@magjac
Fix incorrect zoom test exposed by d3-transition fix
82add26 
The original test was incorrect since it tried to reuse a transition
that had expired. This went unnoticed until
d3/d3-transition#59 was fixed.
@mbostock mbostock mentioned this issue Jul 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2.0 d3/d3-transition
1 participant
@mbostock