generated from d3b-center/d3b-python-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Add file-sample-participant map SQL and file #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
🚨 fix linter violations 🚨 fix linting
used the sqlfluff config in [d3b-dbt repo](https://github.com/d3b-center/d3b-dbt-study-transforms/blob/master/.sqlfluff) as a guide.
chris-s-friedman
force-pushed
the
file-sample-participant-map
branch
from
March 20, 2023 20:33
49886b9
to
ff7a325
Compare
Note that in ff7a325 I added some sqlfluff linting rules to make linting make more sense |
chris-s-friedman
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Nathan! Thanks for working on this!
Merged
chris-s-friedman
added a commit
that referenced
this pull request
Mar 28, 2023
## Release 0.1.0 # ✨ First release of Arcus Manifest Generator Initial release builds the file manifest, participant manifest, and the participant-crosswalk manifest. ### Summary - Emojis: 🚑️ x1, 🐛 x1, 📝 x1, 🎉 x2, 🎨 x1, ♻️ x1, ✏️ x1, ✨ x3, 🚧 x1, ? x1, 🚚 x1, 🔧 x2, 🦺 x1 - Categories: Additions x7, Documentation x1, Fixes x2, Ops x2, Other Changes x5 ### New features and changes - [#19](#19) - 🚑️ use correct column names in file manifest - [d1fdc3d](d1fdc3d) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#18](#18) - 🐛 fix multiple bugs related to parsing mrns and with workflow - [7838c09](7838c09) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#17](#17) - 📝 add documentation for undocumented functions - [4a3a20f](4a3a20f) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#10](#10) - 🎉 Add SQL for file manifest pull - [9c3f792](9c3f792) by [youngnm](https://github.com/youngnm) - [#15](#15) - 🎨 Cleanup - [a362268](a362268) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#16](#16) - ♻️ Add option to allow unvalidated MRNs to not stop code execution - [2335fc4](2335fc4) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#13](#13) - ✏️ save file manifest with correct filename - [0dc4a67](0dc4a67) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#14](#14) - ✨ add participant manifest generator - [147cdee](147cdee) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#12](#12) - ✨ add functionality to generate participant crosswalk - [cc9e0aa](cc9e0aa) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#9](#9) - 🚧 add in a placeholder for qc testing - [d05bde0](d05bde0) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#8](#8) - ✨ setup of tool - [ca13f7a](ca13f7a) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#7](#7) - Design docs - [fa950c6](fa950c6) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#4](#4) - 🎉 Add file-sample-participant map SQL and file - [d8495ec](d8495ec) by [youngnm](https://github.com/youngnm) - [#6](#6) - 🚚 move sqlfluff to root of project so linting works - [db4f666](db4f666) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#5](#5) - 🔧 add sql linting config files - [1c65a0e](1c65a0e) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#2](#2) - 🦺 add validation binary and readme - [e86538b](e86538b) by [calkinsh](https://github.com/calkinsh) - [#1](#1) - 🔧 Repo setup - [178d89d](178d89d) by [chris-s-friedman](https://github.com/chris-s-friedman)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add file-sample-participant map SQL and file
File-sample-participant map for the 2620 files that Bailey provided via email. Attaching here for reference.
arcus-omics-resnick-storm--list.txt
I've imported the attached file to my dev schema in the warehouse (
youngnm_dev_schema
). The SQL joins this file data with the KF data in the warehouse to pull the mapping file.closes #3