👷 Lint PRs #2
👷 Lint PRs #2
Conversation
|
I think this action will do the same thing: https://github.com/marketplace/actions/black-code-formatter |
|
I looked at that also, but it only does black and doesn't flake, and it's not clear to me what value is provided by an action that does so little vs just running the tool. And even if we used that, we'd still need a workflow file to invoke it. |
| @@ -0,0 +1,24 @@ | |||
| name: Python application | |||
There was a problem hiding this comment.
I'm confused by why this is part of release maker? Is it assuming release maker will only run on Python repos?
There was a problem hiding this comment.
This isn't part of release maker. It's linting this repository, which houses python code.
This confusion is actually why I initially had the gh_release.yml file in another folder too. I welcome your thoughts on how to organize things.
[edit: for now I've moved the gh_release.yml back to the central location and symlinked it into this repo's .github/workflows dir (and updated the readme). Hopefully it still works on this repo as a symlink]
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install flake8 black | ||
| - name: Lint |
There was a problem hiding this comment.
Should this step run on *.py? ..I thought I saw that before but it disappeared
There was a problem hiding this comment.
Flake8 automatically does its own search for .py files from . The only reason to avoid using that is to bypass thousands of virtualenv files, but there's no virtualenv here.
mkdir -p foo/bar
echo "import a" > foo/foo.py
echo "import a" > foo/bar/bar.py
flake8 .
./foo/foo.py:1:1: F401 'a' imported but unused
./foo/bar/bar.py:1:1: F401 'a' imported but unused
## Release 1.0.0 ### Summary - Emojis: 👷 x1, 🎉 x1 - Categories: Ops x1, Additions x1 ### New features and changes - [#2](#2) - 👷 Lint PRs - [a5bd6cc](a5bd6cc) by [fiendish](https://github.com/fiendish) - [#1](#1) - 🎉 New release maker - [1c49d0a](1c49d0a) by [fiendish](https://github.com/fiendish)
No description provided.