-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple blocks - complicated refactor #9
base: master
Are you sure you want to change the base?
Conversation
Looks to be about 65% slower Shallow React Component Test Run Average over 10 runs:
Update: it really looks like only half the time went to object creation... Where the rest go? |
Dist is broken by the flatmap polyfill:
|
flatMap is an unnecessary dependency. I inlined a lot of functional stuff and invoked the dark art of imperative programming. |
7ac75e8
to
881472f
Compare
going up as 1.0.0-next.5 |
add simple mapFlat for recursion
This exposes functions for creating elements and wrapping CSS modules by iterating through them as an alternative to #5. closes #2.
Under the hood, it made sense to enforce an AST, since different systems might provide different semantic meaning by default.
This makes it very modular and clean - the internal syntax machinery resolves and then the configured
transformFn
is run for each node.because its doing more traversal and collecting over string building, this might be a lot slower...