Added support for aria-label #78 and role #79 attributes. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelandry
requested changes
Jun 8, 2018
There was a problem hiding this comment.
@rbaheti this looks great! only 2 minor comments to be addressed.
also, in the main body of this PR, if you edit the text so that the word "closes" appears before the issue numbers (ie. closes #78) then the issue will be automatically closed when I merge the PR 😎
https://help.github.com/articles/closing-issues-using-keywords/
src/Shape/Shape.js
Outdated
| @@ -74,6 +75,7 @@ export default class Shape extends BaseClass { | |||
| this._name = "Shape"; | |||
| this._opacity = constant(1); | |||
| this._pointerEvents = constant("visiblePainted"); | |||
| this._role = "presentation"; | |||
There was a problem hiding this comment.
make the default value use the constant function: this._role = constant("presentation");
src/Shape/Shape.js
Outdated
| @@ -44,6 +44,7 @@ export default class Shape extends BaseClass { | |||
| return s * 3; | |||
| } | |||
| }; | |||
| this._ariaLabel = ""; | |||
There was a problem hiding this comment.
make the default value use the constant function: this._ariaLabel = constant("");
|
Great, thanks!
…-Rashmi
On Fri, Jun 8, 2018 at 1:34 PM, Dave Landry ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@rbaheti <https://github.com/rbaheti> this looks great! only 2 minor
comments to be addressed.
also, in the main body of this PR, if you edit the text so that the word
"closes" appears before the issue numbers (ie. closes #78
<#78>) then the issue will
be automatically closed when I merge the PR 😎
https://help.github.com/articles/closing-issues-using-keywords/
------------------------------
In src/Shape/Shape.js
<#81 (comment)>:
> @@ -74,6 +75,7 @@ export default class Shape extends BaseClass {
this._name = "Shape";
this._opacity = constant(1);
this._pointerEvents = constant("visiblePainted");
+ this._role = "presentation";
make the default value use the constant function: this._role =
constant("presentation");
------------------------------
In src/Shape/Shape.js
<#81 (comment)>:
> @@ -44,6 +44,7 @@ export default class Shape extends BaseClass {
return s * 3;
}
};
+ this._ariaLabel = "";
make the default value use the constant function: this._ariaLabel =
constant("");
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#81 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJAu_OE0IuwLuuBgqFuh9LVki6qU7mEKks5t6rWOgaJpZM4Ugoj->
.
|
davelandry
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aria-label #78:
closes add support for "aria-label" attributes #78
role #79 :
closes add support for "role" attribute #79
Types of changes
Checklist