Add linear backoff for http handlers #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuoyenl
reviewed
Mar 24, 2018
handlers/http.go
Outdated
| } | ||
|
|
||
| attempt ++ | ||
| time.Sleep(handler.backoff.Next(attempt)) |
There was a problem hiding this comment.
It seems like strange that it waits for 2*interval after it fails the first time. Also it may not be necessary to increase the wait time based on the attempts. Please just make it wait for interval every time before trying again.
There was a problem hiding this comment.
Hi. Thanks for the comment. I have fix the problem with attempt incrementation before wait. Also I have added Constant backoff(waiting the same interval before attempts) and made it by default. I didn't remove Linear backoff, I think in some cases it can be useful, so now user can specify backoff strategy in options.
shuoyenl
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31