Added -ldflags to floop builds #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euforia
suggested changes
Jul 31, 2017
Makefile
Outdated
| @@ -1,22 +1,40 @@ | |||
|
|
|||
| NAME = floop | |||
| FILES = cmd/main.go cmd/cli.go | |||
| BRANCH = $(shell git rev-parse --abbrev-ref HEAD) | |||
| COMMIT = $(shell git rev-parse --short HEAD) | |||
| VERSION = $(shell git describe | sed -e "s/^v//") | |||
There was a problem hiding this comment.
This line will cause problems if there is no tag present
There was a problem hiding this comment.
Understood. I added an initial tag on the repo so the condition where no tag is present should never happen from now on.
Makefile
Outdated
| @@ -1,22 +1,40 @@ | |||
|
|
|||
| NAME = floop | |||
| FILES = cmd/main.go cmd/cli.go | |||
| BRANCH = $(shell git rev-parse --abbrev-ref HEAD) | |||
There was a problem hiding this comment.
Branch is no longer required and can be removed
Makefile
Outdated
| GOOS=darwin $(BUILD_CMD) -o ./dist/$(NAME)-darwin $(FILES) | ||
| GOOS=windows $(BUILD_CMD) -o ./dist/$(NAME)-windows $(FILES) | ||
|
|
||
| $(eval OS := linux) $(eval OUTFILE := ./dist/$(NAME)-$(OS)-$(VERSION)) |
There was a problem hiding this comment.
Evals are not required for this. You can simple compile each bin with GOOS=linux|darwin|windows. Here's an example dist Makefile block:
dist:
[ -d dist ] || mkdir dist
for os in linux darwin windows; do \
GOOS=$${os} $(BUILD_CMD) $(LD_OPTS) -o dist/$(NAME)-$${os} $(SRC_FILES); \
tar -C dist -czf dist/$(NAME)-$${os}.tgz $(NAME)-$${os}; \
done;
euforia
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue #5