Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] after running the go-pry, terminal changed #21

Closed
jsvisa opened this issue Jul 14, 2017 · 10 comments
Closed

[bug] after running the go-pry, terminal changed #21

jsvisa opened this issue Jul 14, 2017 · 10 comments

Comments

@jsvisa
Copy link

jsvisa commented Jul 14, 2017

After exit the go-pry, any input into the terminal doesn't dis displays.

OS: Ubuntu 16.04
Golang: 1.8.3

@d4l3k
Copy link
Owner

d4l3k commented Jul 14, 2017

How did the terminal change?

Please provide as much info as you can including:

  • Screenshots
  • Description of what changed
  • Terminal emulator + version
  • OS + version
  • Go version

@d4l3k
Copy link
Owner

d4l3k commented Jul 14, 2017

What terminal are you using? The default one?

@jsvisa
Copy link
Author

jsvisa commented Jul 14, 2017

Iterm2 + tmux or the default one the same issue

@d4l3k
Copy link
Owner

d4l3k commented Jul 14, 2017

ITerm2 is for OSX not Ubuntu as far as I'm aware. What's the exact steps you take to reproduce (including sshing, tmux etc)?

@jsvisa
Copy link
Author

jsvisa commented Jul 14, 2017

Sorry,

I'm running Ubuntu by vagrant on Mac OSX, and ssh into the Ubuntu, then runing go-pry

see the screenshot for detail

a

@elisarver
Copy link

I had to stty sane then ^L to get visible user input back.

@whoisjake
Copy link

macOS Sierra - Terminal - bash 4.4.12(1)-release

Run go pry, exit out, no visible characters. Noticed that the output from whatever command starts on the same line.

screen shot 2017-07-14 at 9 24 12 am

@d4l3k
Copy link
Owner

d4l3k commented Jul 14, 2017

I think this happened because #18 didn't properly close the tty. cc @mattn

@d4l3k d4l3k closed this as completed in 517e05b Jul 14, 2017
d4l3k added a commit that referenced this issue Jul 14, 2017
go-tty.Close() on exit. Should fix #21
@mattn
Copy link
Contributor

mattn commented Jul 14, 2017

Ooops. Sorry :(

@whoisjake
Copy link

confirmed works!

screen shot 2017-07-14 at 1 09 41 pm

mattn pushed a commit to mattn/go-pry that referenced this issue Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants