Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for recursive data structures #6

Merged
merged 2 commits into from
May 24, 2016
Merged

Conversation

d4l3k
Copy link
Owner

@d4l3k d4l3k commented May 24, 2016

Fixes #5

@d4l3k d4l3k merged commit 376d1c3 into master May 24, 2016
@d4l3k d4l3k deleted the recursive-structures branch May 24, 2016 02:49
@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage decreased (-1.3%) to 92.727% when pulling 2085c9b on recursive-structures into f96923b on master.

@dmitshur
Copy link

dmitshur commented May 24, 2016

What is the canonical import path of this Go package?

According to the Example in README, it is gopkg.in/d4l3k/messagediff.v1.

If so, #5 is not yet resolved because you've merged this into master, but gopkg.in/d4l3k/messagediff.v1 still points at v1.0.0 tag which hasn't been updated.

If gopkg.in/d4l3k/messagediff.v1 is not the canonical import path of this Go package (i.e., the import path I should be using and one that is supported by you), can you please update the README to say what it is? It's usually done via an Installation section that says go get -u the/canonical/import/path/of/package. E.g., see https://github.com/dominikh/go-js-dom#install.

You can also use an import path comment, e.g., see https://github.com/dominikh/go-js-dom/blob/24aa052bc5c63cfb9383bf59493ee48621ca788c/dom.go#L109.

@d4l3k
Copy link
Owner Author

d4l3k commented May 24, 2016

I'm well aware that v1.0.0 tag hasn't been updated. I just added support but there's still a couple improvements I'm considering before releasing the next version. The issue is fixed since messagediff has support for recursive structures now.

gopkg.in/d4l3k/messagediff.v1 is the canonical stable version. I'll probably release a new stable version later this week.

@dmitshur
Copy link

dmitshur commented May 24, 2016

All right, thank you for fixing it partially! Looking forward to when the fix hits the canonical version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants