Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sui #431

Closed
rollingmoai opened this issue Jun 28, 2023 · 1 comment
Closed

Support Sui #431

rollingmoai opened this issue Jun 28, 2023 · 1 comment
Labels
enhancement New feature, request, improvement or optimization needs info/repro 🤔 Needs more information (from OP?) to be acted upon Root

Comments

@rollingmoai
Copy link

Continuation of #39. Since SD Maid supports Shizuku, it might as well also support Sui, which uses the same APIs as Shizuku.

https://github.com/RikkaApps/Sui
@rollingmoai rollingmoai added enhancement New feature, request, improvement or optimization triage This ticket needs to be sorted and labeled. labels Jun 28, 2023
@rollingmoai rollingmoai reopened this Jun 28, 2023
@rollingmoai rollingmoai mentioned this issue Jun 28, 2023
Closed
@d4rken d4rken added needs info/repro 🤔 Needs more information (from OP?) to be acted upon and removed triage This ticket needs to be sorted and labeled. labels Jun 28, 2023
@d4rken
Copy link
Member

d4rken commented Jun 28, 2023

What is the advantage over what SD Maid already has?

We already use a root launched java service.

sdmaid-se/app-common-root/src/main/java/eu/darken/sdmse/common/root/service/internal/RootHostLauncher.kt

Line 31 in 9e16bc9

class RootHostLauncher @Inject constructor(

It's actually partly based on multiple similar libraries including Sui:

Whether the service is launched via Magisk or Sui shouldn't make a difference, right?

If my code breaks down (I'm not as experienced as Rikka or John Wu in this area) then we could switch to make maintenance easier, but currently it works on all Android versions AFAIK.

@d4rken d4rken added the Root label Jun 28, 2023
@d4rken d4rken closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, request, improvement or optimization needs info/repro 🤔 Needs more information (from OP?) to be acted upon Root
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d4rken @rollingmoai