PR: builtin range function #326 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! I would expect range(0,0) to be [] for consistency. |
|
@geseq Okay, i will change range(0,0) to be [] , any ideas for support for a single parameter? range(5) to [0, 1, 2, 3, 4], current implementions are not supported, if you want, i can support it |
|
I think you might be right and I can see one argument being confusing. I pretty much pulled the idea out of python but we don’t need to stick exactly to python syntax. |
|
@geseq ok, Use the same upper and lower bounds will get empty array ( [] ) as you expect, github action seems to have some problems ? please check this PR. I think it's done now ! |
geseq
approved these changes
Mar 2, 2021
d5
reviewed
Mar 2, 2021
errors.go
Outdated
| @@ -49,6 +49,10 @@ var ( | |||
| // ErrNotImplemented is an error where an Object has not implemented a | |||
| // required method. | |||
| ErrNotImplemented = errors.New("not implemented") | |||
|
|
|||
| // ErrNotImplemented is an error where an Object has not implemented a | |||
|
I've merged a fix for the GitHub Actions to master. Please rebase with master |
|
please fix linting issues too! |
|
emmmm.... okay, I will fix go lint problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add builtin range function:
range(start, stop[, step])
usage examples:
range(0,0) ----> []
range(0, 5) -----> [0, 1, 2, 3, 4]
range(0, 10, 3) -----> [0, 3, 6, 9]
range(0, -10, 2) -----> [0, -2, -4, -6, -8]
special:
The step must be greater than 0 to prevent infinite loops