-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix documentation for enum.filter #359
Conversation
Cool! 👍 I think we should fix the script comment as well. tengo/stdlib/srcmod_enum.tengo Lines 74 to 77 in 09240a1
|
Will do this tomorrow, because I need to run/regenerate go file with this source and I need PC to do this :) |
Sorry, took much longer because of some unexpected additional work I had to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d5
This change seems to be OK but doesn't stdlib/source_modules.go file be updated via go generate
by the maintainers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to the changes though.
I think this PR includes the output of |
I ran |
Ah, I got it. That file should be triggered via I think it's good to go. What do you think? |
Fixes #358