Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation for enum.filter #359

Merged
merged 2 commits into from
Feb 7, 2022
Merged

fix documentation for enum.filter #359

merged 2 commits into from
Feb 7, 2022

Conversation

misiek08
Copy link
Contributor

Fixes #358

@KEINOS
Copy link
Contributor

KEINOS commented Jan 23, 2022

Cool! 👍

I think we should fix the script comment as well.

// filter iterates over elements of `x`, returning an array of all elements `fn`
// returns truthy for. `fn` is invoked with two arguments: `key` and `value`.
// `key` is an int index if `x` is array. `key` is a string key if `x` is map.
// It returns undefined if `x` is not enumerable.

@misiek08
Copy link
Contributor Author

Will do this tomorrow, because I need to run/regenerate go file with this source and I need PC to do this :)

@misiek08
Copy link
Contributor Author

misiek08 commented Feb 1, 2022

Sorry, took much longer because of some unexpected additional work I had to do.

Copy link
Contributor

@KEINOS KEINOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d5
This change seems to be OK but doesn't stdlib/source_modules.go file be updated via go generate by the maintainers?

Copy link
Contributor

@KEINOS KEINOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to the changes though.

@d5
Copy link
Owner

d5 commented Feb 5, 2022

I think this PR includes the output of go generate as well, right? @misiek08

@misiek08
Copy link
Contributor Author

misiek08 commented Feb 6, 2022

I ran go run gensrcmods.go

@KEINOS
Copy link
Contributor

KEINOS commented Feb 6, 2022

@misiek08

I ran go run gensrcmods.go

Ah, I got it.

That file should be triggered via go generate ./... defined in stdlib/stdlib.go's header, I think.
They will be overwritten anyway, but the fewer files to review, the better, right?

@d5

I think it's good to go. What do you think?

@d5 d5 merged commit 7b5d207 into d5:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy between "enum" package documentation and its behavior
3 participants