Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go version to fix goreleaser #422

Merged
merged 1 commit into from
Apr 23, 2023
Merged

update go version to fix goreleaser #422

merged 1 commit into from
Apr 23, 2023

Conversation

geseq
Copy link
Collaborator

@geseq geseq commented Apr 23, 2023

No description provided.

@geseq
Copy link
Collaborator Author

geseq commented Apr 23, 2023

@d5 can I get an approval please

@d5
Copy link
Owner

d5 commented Apr 23, 2023

Thanks for taking care of this @geseq!

I know it’s only release and test actions, but can this somehow break backward compatibility for those who are using Tengo from 1.16 codebase?

@geseq
Copy link
Collaborator Author

geseq commented Apr 23, 2023

It probably won’t work with 1.16 if someone upgraded to recent versions due to the math constants but 1.17 would be fine.

1.16 is fairly old and has been end of life for a fairly long time now so I’m not really sure it’s worth worrying about.

@d5
Copy link
Owner

d5 commented Apr 23, 2023

Got it. Should we just start a new major version v3 and change the minimum supported version to Go 1.18?

@geseq
Copy link
Collaborator Author

geseq commented Apr 23, 2023

I don’t mind either way. Historically we’ve just maintained compatibility with the last 3 major versions of Go.

Personally to me v3 seems a bit of an overkill since the changes are mostly bug fixes and library expansions and not really major changes to tengo itself

Copy link
Owner

@d5 d5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. We didn't have any major changes in Tengo. Maybe I wanted to change the major version mostly because we're using semantic versioning - breaking changes should increase the major version. Let's merge this one, but maybe we should consider using different versioning scheme starting from v3 in the future.

@geseq geseq merged commit 55f2519 into master Apr 23, 2023
@geseq
Copy link
Collaborator Author

geseq commented Apr 23, 2023

Makes sense!

@geseq geseq deleted the fix-goreleaser branch April 23, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants