-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new LCGS parser with better parse errors #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
When migrating to new parser we should be aware if we are backwards-compat. If we are, then only minor-version needs to be bumped, otherwise another major bump required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a new LCGS parser. Instead of using
pom
it is now a handmade lexer and recursive-descent parser. This PR is the second step towards #42, #104, and #190.This PR includes:
This PR does NOT replace/remove the old LCGS parser. The old LCGS parser that uses
pom
is still in use for now as the semantic analysis ofIntermediateLCGS
(the symbol checking and relabeling) still uses the old AST. This will change in the next PR on this topic.