Fixes for login plugins #27
Conversation
| user_login_finalize($user); | ||
|
|
||
| // TODO Should finalize() be after user_login_finalize or before?! |
There was a problem hiding this comment.
I'm not sure, but let's try this and possibly note it in an issue to explore it moving fwd.
| * @param array $configuration | ||
| * @return array|null | ||
| */ | ||
| public function getPlugins($configuration = array()){ |
There was a problem hiding this comment.
Do we need this?
I wrote this for password policy and we didn't use it - https://github.com/d8-contrib-modules/password_policy/blob/master/src/PasswordConstraintPluginManager.php
There was a problem hiding this comment.
I think you actually use functions in the default plugin manager(e.g. getInstances) to retrieve the plugins
There was a problem hiding this comment.
I'm using getPlugins to get the selected plugins and use them in buildForm. I had no other idea on how to do that. see #29 - maybe I should redo this pull req in other way. Thx
|
@dragos-dumi - I sent you an invite so you could join our collaboration group. Please accept it, so you can add issues, assign yourself issues, and it will be clear what you are working on for the other participants. |
|
Merging. |
No description provided.