Update smartprocess.py #30
Open
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change indentation to restore pad functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went to use the padding function and it didn't work for me, so I did some digging and it looks like the padding functionality was broken by the following commit:
1def06d#diff-d56db42c60f8fc9165345312bcb110d898f38738e8206e548039e86b9b3245fd
It appears that the original issue was unintentional padding when not selecting "pad" in the UI, however I believe the intended solution was to indent lines 377-340, rather than 325-350 which ended up in the commit. The current state of the code is such that "pad" can only be reached within "crop." I have adjusted the indentation to restore padding without bringing back the original issue; I believe the unintentional padding was caused by 377-340 not being indented, so there was no conditional checking the "if not cropped properly, crop again" catch there.
Addresses issue: #27 as well :)