make ccache usage optional #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hsdk123 - thanks for contributing! I think the PR makes sense, I'll try get it merged soon (probably next weekend). |
|
I've made some follow-up changes (integrated via PR #148), which enables ccache only when rapidcsv test suite build is enabled. This means it'll be disabled by default, so it'll minimize the risk of ccache causing issues for projects using rapidcsv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I notice rapidcsv pulls in ccache as a global which can cause bugs
ex. https://gitlab.kitware.com/cmake/cmake/-/issues/21328
This is a PR make this an option that the user can configure.