srm: add default port numbers for 3rd party copy

SRM supports third-party copy of files, where the user tells the system 
to copy data from some third-party server.

Currently, if the user doesn't specify the port number (e.g., 
http://www.example.org/path/to/data) then the system will attempt to 
use '-1' as the port number.

This patch updates this behaviour so well-established default values 
are used if no port number is specified.

FOR RELEASE NOTES:

Mention that third-party copies no longer require the port number to be 
specified.  If a port isn't specified in the URI then the 
well-established default value for that protocol is used.

Target: trunk
Require-notes: yes
Require-book: no
Patch: http://rb.dcache.org/r/5206/
Acked-by: Tigran Mkrtchyan

Author: paulmillar

modules/dcache/src/main/java/diskCacheV111/srm/dcache/Storage.java

@@ -2024,6 +2024,33 @@ public void killRemoteTransfer(String transferId) {
         }
     }
 
+    private static int portFor(URI target) throws SRMException
+    {
+        if(target.getPort() != -1) {
+            return target.getPort();
+        }
+
+        String scheme = target.getScheme();
+
+        if(scheme == null) {
+            throw new SRMException("No scheme in URI " + target.toString());
+        }
+
+        // REVISIT consider taking default port numbers from /etc/services
+
+        switch(scheme.toLowerCase()) {
+            case "http":
+                return 80;
+            case "https":
+                return 443;
+            case "gsiftp":
+                return 2811;
+            default:
+                throw new SRMException("No default port number for " +
+                        target.toString());
+        }
+    }
+
     private String performRemoteTransfer(SRMUser user,
                                          URI remoteTURL,
                                          FsPath actualFilePath,
@@ -2045,6 +2072,8 @@ private String performRemoteTransfer(SRMUser user,
 
         IpProtocolInfo protocolInfo;
 
+        int port = portFor(remoteTURL);
+
         if (remoteTURL.getScheme().equals("gsiftp")) {
             RequestCredential credential =
                 RequestCredential.getRequestCredential(remoteCredentialId);
@@ -2057,7 +2086,7 @@ private String performRemoteTransfer(SRMUser user,
             RemoteGsiftpTransferProtocolInfo gsiftpProtocolInfo =
                 new RemoteGsiftpTransferProtocolInfo("RemoteGsiftpTransfer",
                                                      1, 1,
-                                                     new InetSocketAddress(remoteTURL.getHost(), remoteTURL.getPort()),
+                                                     new InetSocketAddress(remoteTURL.getHost(), port),
                                                      remoteTURL.toString(),
                                                      getCellName(),
                                                      getCellDomainName(),
@@ -2073,7 +2102,7 @@ private String performRemoteTransfer(SRMUser user,
             protocolInfo =
                 new RemoteHttpDataTransferProtocolInfo("RemoteHttpDataTransfer",
                                                        1, 1,
-                                                       new InetSocketAddress(remoteTURL.getHost(), remoteTURL.getPort()),
+                                                       new InetSocketAddress(remoteTURL.getHost(), port),
                                                        config.getBuffer_size(),
                                                        remoteTURL.toString());
         } else {