Skip to content

Commit 97f7014

Browse files
committed
pool: Improve logging of common errors
Improve log levels and log messages of common errors found in production log files. Target: trunk Require-book: no Require-notes: yes Ticket: http://rt.dcache.org/Ticket/Display.html?id=7685 Acked-by: Paul Millar <paul.millar@desy.de> Acked-by: Dmitry Litvinsev <litvinse@fnal.gov> Patch: http://rb.dcache.org/r/5255/ (cherry picked from commit 5302c40)
1 parent 9b9d76c commit 97f7014

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

modules/dcache/src/main/java/org/dcache/pool/classic/DefaultPostTransferService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public void run()
123123
mover.setTransferStatus(CacheException.UNEXPECTED_SYSTEM_EXCEPTION,
124124
"Transfer failed in post-processing: " + e.getMessage());
125125
} catch (RuntimeException e) {
126-
LOGGER.error("Transfer failed in post-processing due to unexpected exception", e);
126+
LOGGER.error("Transfer failed in post-processing. Please report this bug to support@dcache.org.", e);
127127
mover.setTransferStatus(CacheException.UNEXPECTED_SYSTEM_EXCEPTION,
128128
"Transfer failed due to unexpected exception: " + e.getMessage());
129129
} catch (Throwable e) {

modules/dcache/src/main/java/org/dcache/pool/classic/PoolV4.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1961,7 +1961,9 @@ private String mover_set_max_active(IoScheduler js, Args args)
19611961
return sb.toString();
19621962
}
19631963

1964-
public Object ac_mover_ls_$_0_1(Args args) throws NoSuchElementException {
1964+
public Object ac_mover_ls_$_0_1(Args args)
1965+
throws NoSuchElementException, NumberFormatException
1966+
{
19651967
String queueName = args.getOpt("queue");
19661968
boolean binary = args.hasOption("binary");
19671969

@@ -1994,6 +1996,7 @@ private String mover_set_max_active(IoScheduler js, Args args)
19941996
}
19951997

19961998
public Object ac_p2p_ls_$_0_1(Args args)
1999+
throws NoSuchElementException, NumberFormatException
19972000
{
19982001
IoScheduler p2pQueue = _ioQueue.getQueue(P2P_QUEUE_NAME);
19992002

0 commit comments

Comments
 (0)