Skip to content

Commit d11d1cf

Browse files
committed
spacemanager: unknown message have to be sent to Poolmanager
as SpaceManager works as a proxy, not all messages handled as expected. Ticket: 7844 Acked-by: Gerd Behrmann Target: trunk, 2.6 Require-book: no Require-notes: yes Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
1 parent 0f16934 commit d11d1cf

File tree

1 file changed

+20
-12
lines changed
  • modules/dcache/src/main/java/diskCacheV111/services/space

1 file changed

+20
-12
lines changed

modules/dcache/src/main/java/diskCacheV111/services/space/Manager.java

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3506,21 +3506,31 @@ private void handleMessageAsDisabled(CellMessage cellMessage)
35063506

35073507
Message message = (Message) cellMessage.getMessageObject();
35083508

3509-
if (message instanceof PoolMgrSelectPoolMsg) {
3510-
3511-
forwardToPoolmanager(cellMessage);
3512-
3513-
} else if (message instanceof PoolFileFlushedMessage ||
3509+
if (message instanceof PoolFileFlushedMessage ||
35143510
message instanceof PoolRemoveFilesMessage ||
35153511
message instanceof PnfsDeleteEntryNotificationMessage) {
35163512

35173513
// Simply ignore these notification messages
35183514

3519-
} else if (message.getReplyRequired()) {
3515+
} else if (message instanceof Reserve
3516+
|| message instanceof GetSpaceTokensMessage
3517+
|| message instanceof GetSpaceTokenIdsMessage
3518+
|| message instanceof GetLinkGroupsMessage
3519+
|| message instanceof GetLinkGroupNamesMessage
3520+
|| message instanceof GetLinkGroupIdsMessage
3521+
|| message instanceof Release
3522+
|| message instanceof Use
3523+
|| message instanceof CancelUse
3524+
|| message instanceof GetSpaceMetaData
3525+
|| message instanceof GetSpaceTokens
3526+
|| message instanceof ExtendLifetime
3527+
|| message instanceof GetFileSpaceTokensMessage ) {
35203528

35213529
returnFailedResponse("SpaceManager is disabled in configuration",
35223530
message, cellMessage);
35233531

3532+
} else {
3533+
forwardToPoolmanager(cellMessage);
35243534
}
35253535
}
35263536

@@ -3618,12 +3628,10 @@ else if (spaceMessage instanceof PnfsDeleteEntryNotificationMessage) {
36183628
markFileDeleted(msg);
36193629
}
36203630
else {
3621-
logger.error("unknown message, type {} " +
3622-
"value {}",
3623-
spaceMessage.getClass().getName(),
3624-
spaceMessage);
3625-
super.messageArrived(cellMessage);
3626-
return;
3631+
if (!spaceMessage.isReply()) {
3632+
forwardToPoolmanager(cellMessage);
3633+
}
3634+
return;
36273635
}
36283636
}
36293637
catch(SpaceException se) {

0 commit comments

Comments
 (0)