Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent cooked mode from creating messages with empty values #10

Merged
merged 1 commit into from
Nov 24, 2017
Merged

prevent cooked mode from creating messages with empty values #10

merged 1 commit into from
Nov 24, 2017

Conversation

gjvc
Copy link
Contributor

@gjvc gjvc commented Nov 23, 2017

...but still allow the use of raw mode for expert use.

@gjvc
prevent cooked mode from creating messages with empty values
c1daf34 
...but still allow the use of raw mode for expert use.
@coveralls
Copy link

coveralls commented Nov 23, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 95.23% when pulling c1daf34 on gjvc:patch-1 into ee682ab on da4089:master.

@da4089 da4089 merged commit 1355685 into da4089:master Nov 24, 2017
@da4089
Copy link
Owner

da4089 commented Nov 24, 2017

@gjvc, how were you able to get a None value into the pairs list? In looking at append_pair(), it converts everything using fix_val(), which will change None to a byte-string b"None" in both 2.7 and 3.6, I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjvc @coveralls @da4089