No sleeping. No clearing. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: I haven't tested this; it's just a quick edit to let you see where I'm going with this. Please test it and make sure that it doesn't break anything. Sleeping for informational purposes is no good. If the user misses a message (or, god forbid, an opportunity to abort under certain circumstances), that's bad. Prompt for choices, die on errors and otherwise let it scroll by. If they really need something from the process, put it at the end as I've done here. If they really want to see other messages, they can log them somewhere or use a scrollback buffer (or you can log them with a custom routine, which you probably should at some point). Also, clearing the screen looks cool and tidy at first, but it means data is lost, and you will find that many users find the experience disconcerting: "What was that I saw when I looked back after looking away for a moment? Was it important?".
|
Agreeing with logic presented here. Will test code changes tomorrow and merge upon verification that fixes work as intended. |
da667
added a commit
that referenced
this pull request
Aug 23, 2012
No sleeping. No clearing. Approved: da667.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I haven't tested this; it's just a quick edit to let you see where I'm going with this. Please test it and make sure that it doesn't break anything.
Sleeping for informational purposes is no good. If the user misses a message (or, god forbid, an opportunity to abort under certain circumstances), that's bad. Prompt for choices, die on errors and otherwise let it scroll by. If they really need something from the process, put it at the end as I've done here. If they really want to see other messages, they can log them somewhere or use a scrollback buffer (or you can log them with a custom routine, which you probably should at some point).
Also, clearing the screen looks cool and tidy at first, but it means data is lost, and you will find that many users find the experience disconcerting: "What was that I saw when I looked back after looking away for a moment? Was it important?".