Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itch.io social link #788

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Itch.io social link #788

merged 2 commits into from
Mar 11, 2021

Conversation

Emaleth
Copy link
Contributor

@Emaleth Emaleth commented Mar 11, 2021

Added Itch.io to social links

@daattali
Copy link
Owner

Have you tested this to make sure the fontawesome version used in this theme has this icon?

Please also add an entry in the CHANGELOG file

@Emaleth
Copy link
Contributor Author

Emaleth commented Mar 11, 2021

Added entry in CHANGELOG.md (under unreleased) but cant find FA in head or anywhere, could you tell me where to find info / tell what version you use?

@Emaleth
Copy link
Contributor Author

Emaleth commented Mar 11, 2021

Ok, found it. Yes, it is in version 5.

@daattali
Copy link
Owner

daattali commented Mar 11, 2021

Have you tested this? Can you please provide a link to a repository where this is implemented

@Emaleth
Copy link
Contributor Author

Emaleth commented Mar 11, 2021

https://emaleth.dev
https://github.com/emaleth/emaleth.github.io
(keep in mind it's just social include, its still of original repo via remote_theme, but since other files were not modified it should suffice.

@daattali daattali merged commit 7248ed9 into daattali:master Mar 11, 2021
@daattali
Copy link
Owner

Thanks!

krisfail pushed a commit to krisfail/old-blog-archived that referenced this pull request Jun 27, 2021
OCram85 added a commit to OCram85/beautifulSA-jekyll that referenced this pull request Aug 2, 2021
* fix(daattali#744): Escape special characters in title (daattali#745)

* add matt artist as sponsor

* Fix margin top alignment issue on Safari (daattali#750)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Remove references to any public Staticman API instance (daattali#775)

* Update CHANGELOG.md

* Adding option for Medium Social Link at footer  (daattali#784)

* Itch.io social link (daattali#788)

* Update CHANGELOG.md

* Add support for Cloudflare analytics (daattali#798)

* Include Reddit in share options of posts (daattali#815)

* add search to the navbar using 'post_search' config param

* Update CHANGELOG.md

* ui: make sure search results dont have underline until hovered

* search feature: make sure page scrollbar disappears when searching but a scrollbar for search items shows if needed

* update changelog

Co-authored-by: Dmitry <dmitry.b.danilov@gmail.com>
Co-authored-by: Dean Attali <dean@attalitech.com>
Co-authored-by: Amy Troschinetz <lexicalunit@lexicalunit.com>
Co-authored-by: Dean Attali <daattali@gmail.com>
Co-authored-by: Vincent Tam <VincentTam@users.noreply.github.com>
Co-authored-by: Diksha Verma <112dikshaverma@gmail.com>
Co-authored-by: Emaleth <Emaleth@protonmail.com>
Co-authored-by: Ari Kalfus <dev@artis3nal.com>
Co-authored-by: Leedan <l33d4n@gmail.com>
Co-authored-by: Marco Blessing <marco.blessing@komm.one>
jeffreysimpson pushed a commit to the-galah-survey/the-galah-survey.github.io that referenced this pull request Sep 25, 2021
kishore-raj pushed a commit to kishore-raj/beautiful-jekyll that referenced this pull request Jan 24, 2022
GuillermoFidalgo pushed a commit to GuillermoFidalgo/OldSite-guillermofidalgo that referenced this pull request Apr 3, 2022
SeanieGleason pushed a commit to SeanieGleason/seaniegleason.github.io that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants