Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes in a post title cut the title in the social preview #744

Closed
f-squirrel opened this issue Nov 24, 2020 · 2 comments · Fixed by #745
Closed

Quotes in a post title cut the title in the social preview #744

f-squirrel opened this issue Nov 24, 2020 · 2 comments · Fixed by #745

Comments

@f-squirrel
Copy link
Contributor

I've noticed that if a post has quotes in its title then when the post is shared on Facebook or Twitter, only the part before the quotes is shown.
Example:

title: The "moving" truth behind std::optional

=> The preview shows everything before the quote:

The
<excerpt>
<share-img>

When I remove the quotes:

title: The moving truth behind std::optional

=> The preview shows the full title:

The moving truth behind std::optional
<excerpt>
<share-img>

I've tried to put \" but it did not help.

I am not sure if it is a bug or misconfiguration, I'd be happy if anybody has any leads to offer.

P.S. I am really grateful for this awesome theme and the whole work that Dean and the contributors are doing!
@daattali
Copy link
Owner

This seems like an escaping issue, I'm probably not escaping the title somewhere where it should be escaped. I'd be happy for a PR!

@f-squirrel f-squirrel mentioned this issue Nov 24, 2020
Merged
@f-squirrel
Copy link
Contributor Author

@daattali , I've created a PR(#745).
I am pretty new to HTML/Ruby, but it worked for me.

f-squirrel added a commit to f-squirrel/beautiful-jekyll that referenced this issue Nov 27, 2020
@f-squirrel
fix(daattali#744): Escape special characters in title
84c9ad0
daattali pushed a commit that referenced this issue Nov 27, 2020
@f-squirrel
fix(#744): Escape special characters in title (#745)
e8de772
OCram85 added a commit to OCram85/beautifulSA-jekyll that referenced this issue Jan 23, 2021
@OCram85 @f-squirrel
@daattali @lexicalunit
Merge upstream updates (#2)
05c08af 
* fix(daattali#744): Escape special characters in title (daattali#745)

* add matt artist as sponsor

* Fix margin top alignment issue on Safari (daattali#750)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Co-authored-by: Dmitry <dmitry.b.danilov@gmail.com>
Co-authored-by: Dean Attali <dean@attalitech.com>
Co-authored-by: Amy Troschinetz <lexicalunit@lexicalunit.com>
Co-authored-by: Dean Attali <daattali@gmail.com>
OCram85 added a commit to OCram85/beautifulSA-jekyll that referenced this issue Feb 15, 2021
@OCram85 @f-squirrel
@daattali @lexicalunit @VincentTam
Merge/2021 02 15 (#3)
5e52982 
* fix(daattali#744): Escape special characters in title (daattali#745)

* add matt artist as sponsor

* Fix margin top alignment issue on Safari (daattali#750)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Remove references to any public Staticman API instance (daattali#775)

* Update CHANGELOG.md

Co-authored-by: Dmitry <dmitry.b.danilov@gmail.com>
Co-authored-by: Dean Attali <dean@attalitech.com>
Co-authored-by: Amy Troschinetz <lexicalunit@lexicalunit.com>
Co-authored-by: Dean Attali <daattali@gmail.com>
Co-authored-by: Vincent Tam <VincentTam@users.noreply.github.com>
OCram85 added a commit to OCram85/beautifulSA-jekyll that referenced this issue Aug 2, 2021
@OCram85 @f-squirrel
@daattali @lexicalunit @VincentTam @zenithexpo @Emaleth @artis3n @l33d4n
Fetch upstream (#5)
6a84cef 
* fix(daattali#744): Escape special characters in title (daattali#745)

* add matt artist as sponsor

* Fix margin top alignment issue on Safari (daattali#750)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Remove references to any public Staticman API instance (daattali#775)

* Update CHANGELOG.md

* Adding option for Medium Social Link at footer  (daattali#784)

* Itch.io social link (daattali#788)

* Update CHANGELOG.md

* Add support for Cloudflare analytics (daattali#798)

* Include Reddit in share options of posts (daattali#815)

* add search to the navbar using 'post_search' config param

* Update CHANGELOG.md

* ui: make sure search results dont have underline until hovered

* search feature: make sure page scrollbar disappears when searching but a scrollbar for search items shows if needed

* update changelog

Co-authored-by: Dmitry <dmitry.b.danilov@gmail.com>
Co-authored-by: Dean Attali <dean@attalitech.com>
Co-authored-by: Amy Troschinetz <lexicalunit@lexicalunit.com>
Co-authored-by: Dean Attali <daattali@gmail.com>
Co-authored-by: Vincent Tam <VincentTam@users.noreply.github.com>
Co-authored-by: Diksha Verma <112dikshaverma@gmail.com>
Co-authored-by: Emaleth <Emaleth@protonmail.com>
Co-authored-by: Ari Kalfus <dev@artis3nal.com>
Co-authored-by: Leedan <l33d4n@gmail.com>
Co-authored-by: Marco Blessing <marco.blessing@komm.one>
jeffreysimpson pushed a commit to the-galah-survey/the-galah-survey.github.io that referenced this issue Sep 25, 2021
@f-squirrel
fix(daattali#744): Escape special characters in title (daattali#745)
81f31b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#744): Escape special characters in title f-squirrel/beautiful-jekyll
2 participants
@daattali @f-squirrel