Fixes for readr 1.2.0 #21
Conversation
readr 1.2.0 no longer guesses columns are of type integer, rather these columns are always guessed as type double. This breaking change caused two errors in your ddpcr package, fixed by the changes in this commit.
|
Did you manually make PRs for every package that was broken or was this somehow crazily automated? I think I'll just wait until the CRAN release and then make the changes rather than changing to Remote dependency, unless there's a good reason not to |
|
Only three packages broke, so it was easy to send PRs to fix them. |
|
Any ETA on CRAN submission? Within a month or 6? |
|
Today if possible, (not saying you need to release this today, but I was going to submit readr to CRAN today). |
|
Ah ok so I'll put in my calendar to check at the end of the weekend if it's on CRAN yet and then merge, thanks! |
|
Submitting to CRAN never goes as smoothly as you think :) |
|
@jimhester Still battling it out with CRAN? I'll keep checking to see when I need to merge :) |
|
There is no battle, they are just ignoring my readr submissions |
|
Oh, that I did not expect.. :S |
|
@jimhester looks like readr finally went through! I can't imagine what kind of CRAN check hell was going on for such a delay to happen... |
|
Thank you so much for this PR, I would have easily spent 1-2 hours figuring out what's wrong because CRAN tests are now failing. |
readr 1.2.0 no longer guesses columns are of type integer, rather these
columns are always guessed as type double.
This breaking change caused two errors in your ddpcr package, fixed by
the changes in this commit.
Sorry for the breakage!