Windows support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the only tests we currently have are tests of code in executable example targets, and that's not yet supported on Windows, the Windows build currently doesn't have any tests. However, more tests, not dependent on the examples, should be written and those would run just fine on Windows in CI.
Note also that getting the build tool to run on Windows required the use of SPMBuildToolSupport. In 1c86a12 that was included in the project using
git-subtreein lieu ofgit-submodule, which can create usability issues for the unwary. That does add a lot of source to this project, and if you don't like that effect we could just copy the oneSPMBuildToolSupport.swiftfile from that project into the plugin source directory. Usinggit-subtree, though, should make it easier to track changes if/when SPMBuildToolSupport is updated./cc @roop