Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

human-readable filesize #204

Closed
benwalch opened this issue Sep 6, 2023 · 1 comment
Closed

human-readable filesize #204

benwalch opened this issue Sep 6, 2023 · 1 comment
Labels
enhancement
Milestone
4.1.1

Comments

@benwalch
Copy link
Member

benwalch commented Sep 6, 2023

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

The calculation for human-readable file sizes is wrong for specific cases.
For example, a file having 1033760 bytes (~ 1 MB) will be displayed as "1 KB"
benwalch added a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable filesize (#204)
f264855
benwalch added a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable file size (#204)
bf801fc
This was referenced Sep 6, 2023
Merged
Merged
benwalch added a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable filesize (#204)
f2ffdf5
benwalch added a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable filesize (#204)
49e17d3
benwalch added a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable filesize (#204)
1ad4bd9
benwalch added a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable file size (#204)
b959568
solverat pushed a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable filesize (#204) (#206)
830e71f
solverat pushed a commit that referenced this issue Sep 6, 2023
@benwalch
fix human-readable file size (#204) (#205)
62ac811
@solverat
Copy link
Member

fixed with #205, #206 .

@solverat solverat added this to the 4.1.1 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
2 participants
@solverat @benwalch