🚀 Performance enhancements #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 7, 2017 15:03
…hub.com/dadi/web into feature/http2 # Conflicts: # dadi/lib/index.js
jimlambie
reviewed
Aug 10, 2017
dadi/lib/view/public.js
Outdated
| } | ||
| } | ||
|
|
||
| Public.prototype.openStream = function ( |
There was a problem hiding this comment.
use an object argument instead? { res: res, file: file } ?
jimlambie
reviewed
Aug 10, 2017
scripts/init-web.js
Outdated
| @@ -1,23 +1,27 @@ | |||
| #! /usr/bin/env node | |||
|
|
|||
| var fs = require('fs') | |||
| var path = require('path') | |||
| var fs = require("fs") | |||
There was a problem hiding this comment.
single quotes preferred 😬
jimlambie
approved these changes
Aug 29, 2017
added 3 commits
August 29, 2017 13:58
added 6 commits
August 31, 2017 10:39
…formance # Conflicts: # config.js # dadi/lib/index.js # package.json
|
This is an awesome effort @abovebored 🚀 🌔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains most of the improvements from the on hold #167.
Closes #174.
Closes #175.
Closes #158.
Closes #168.
Closes #173.
Closes #51.
Closes #212.
Features
/lib/view/public.js) for serving from the public folder - removed need for Express modules serve-static and serve-favicon.config.headers.useGzipCompressiontoconfig.headers.useCompressionhelp.canCompresswhich determines if caching is enabled on the system and tests if the client can accept a compressed outputzlibforgzipif not available)sendBackJSON,sendBackHTMLintoview/send.jssendBackJSONPconfig.headers.useCompressionmediapath.cachingis specified in the config.api/flush. Added corresponding error page when method is notPOST.sinonat version 2 (3 not compatible withsinon-testyet)npm run formatto run for standard & prettierenvisproductionTo-do