Use full request url as cache key #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambie
changed the title
eduardoboucas
approved these changes
Apr 18, 2019
dadi/lib/cache/index.js
Outdated
| @@ -189,7 +189,7 @@ Cache.prototype.init = function () { | |||
|
|
|||
| // we build the filename with a hashed hex string so we can be unique | |||
| // and avoid using file system reserved characters in the name | |||
| const requestUrl = url.parse(req.url, true).path | |||
| const requestUrl = req.url | |||
There was a problem hiding this comment.
My only comment would be that requestUrl now becomes a bit redundant (and actually longer in length than just req.url), but I'm not strongly against it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue highlighted in issue #489 whereby the querystring parameters of a URL were not taken into account when constructing a cache key.