-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New oauth2_client_credentials
finalizer
#959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #959 +/- ##
==========================================
+ Coverage 89.30% 89.50% +0.20%
==========================================
Files 238 239 +1
Lines 9666 9922 +256
==========================================
+ Hits 8632 8881 +249
- Misses 806 812 +6
- Partials 228 229 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…an friendly error messages
dadrus
added a commit
that referenced
this pull request
Oct 10, 2023
dadrus
added a commit
that referenced
this pull request
Oct 10, 2023
A huge thank you to @netthier for review and support! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #882
Checklist
Description
New finalizer, capable driving the OAuth2 Client Credentials flow.
CONFIGURATION UPDATES:
New
oauth2_client_credentials
finalizer with following configuration options for the heimdall config:with
token_url
- The OAuth2 provider token URL (mandatory)client_id
- The client id to use (mandatory)client_secret
- The client secret to use (mandatory)auth_method
- How to transfer the client_id and client_secret (optional). Can be eitherbasic_auth
(which is the default) orrequest_body
. In first case the client_id and client_secret are sent in theAuthorization
header using theBearer
scheme. In latter case the client_id and client_secret are sent in the body of the request.cache_ttl
- How long to cache the token (optional). Defaults to the value of theexpires_in
value from the token endpoint response. Ifexpires_in
is not present in the response, the token is not cached until this property (cache_ttl
) is not explicitly configured. Ifexpires_in
is present in the response and this property is configured the shorter value is taken (basically the result frommin(cache_ttl, expires_in)
is used in that case). Negative value forcache_ttl
disables caching entirely.scopes
- A list of scopes required (optional)header
- Which header to set to transport the issued token and using which scheme (optional). If not setAuthorization
header withBearer
scheme is used. Note, the scheme from the token endpoint response is ignored.In the rule only,
cache_ttl
,scopes
andheader
can be overridden.