Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with /ac in CN client #65

Closed
joesh1n opened this issue Apr 25, 2022 · 13 comments
Closed

Issue with /ac in CN client #65

joesh1n opened this issue Apr 25, 2022 · 13 comments

Comments

@joesh1n
Copy link

joesh1n commented Apr 25, 2022

Using the CN client, the crafts were being started from the RecipeNote interface normally, however, when it comes to executing any of the /ac lines, there was an error message of "Could not parse progress number in the Synthesis addon: Failure while running /ac X", with X being the name of the action in Chinese, such as 坚信 for Muscle Memory. Using English macro lines simply don't do anything.
Is there any workaround for this?

@AsterNighT
Copy link

Same issue here. Would provide info for the problem if necessary.

@daemitus
Copy link
Owner

daemitus commented Apr 26, 2022 via email

@daemitus
Copy link
Owner

ok.

  • open the Synthesis window, trial synth is fine.
  • run /xldata ai
  • On the left hand side of the data window...
    • navigate to "Loaded Units" then "Synthesis"
  • On the right hand side of the data window...
    • expand "Node List"
    • the progress nodes are numbers 46, 47, and 48 for me. 46 is max, 47 is current, 48 is the "/" between them. If you expand the node, you can view the text itself for verification.
    • check that these are as expected, and we can continue troubleshooting.

Screenshot 2022-04-26 172607

@daemitus
Copy link
Owner

On another note, does using the english names work, or are you required to use the CN ones?
does /ac "Muscle Memory" do anything in a regular macro?

@RyotaMono
Copy link

RyotaMono commented Apr 27, 2022

In CN client,

for Progress:

  • Text node 41 is max.
  • Text node 42 is current.
  • Text node 43 is the "/" sign.

for Quality:

  • Text node 35 is max.
  • Text node 36 is current.
  • Text node 37 is the "/" sign.

It is required to use the CN ones. /ac with English skill name results in a skill not found error.

@RyotaMono
Copy link

RyotaMono commented Apr 27, 2022

FYI, the issue may come from the updates in March/April. Old SND client with AseemblyVersion of 1.2.2.7 works fine.

@daemitus
Copy link
Owner

daemitus commented Apr 27, 2022 via email

@RyotaMono
Copy link

RyotaMono commented Apr 27, 2022

Thanks for your quick reply. Sorry, I don't quite understand. What is "the update"? Should I post screenshots of both the FFXIV synthesis window and the SND panel?

Does your synthesis window show the collectability numbers, and have the different colored quality bar? It sounds like you haven't gotten the update for it.

@daemitus
Copy link
Owner

daemitus commented Apr 27, 2022 via email

@RyotaMono
Copy link

RyotaMono commented Apr 27, 2022

Not yet, there is a 6-month lag between the update of other global clients and the CN client. Currently, the CN client is at version 6.05 (updated at 04/26, yesterday). The 6.0 version was updated only about a month ago.

@RyotaMono
Copy link

Thanks so much for your hints, and your time to develop the plugin.

I tried the old AddonSynthesis.cs file before the recent ffxiv update. Link: AddonSynthesis.cs. After replacing lib\FFXIVClientStructs\FFXIVClientStructs\FFXIV\Client\UI\AddonSynthesis.cs with the older one and rebuild the whole project, the problem is solved.

@daemitus
Copy link
Owner

Ok, i took the old addonsynthesis, built and uploaded as SND 6.05-CN to the repo. It won't get any updates automatically, but is current as of right now.

Let me know if there are any more problems.

@yjywybb
Copy link

yjywybb commented May 14, 2022

It seem that you put the same link in Something Need Doing 6.05 CN as Something Need Doing

    "Author": "daemitus",
    "Name": "Something Need Doing 6.05 CN",
    "Punchline": "Work work.",
    "Description": "A hard-working peon that crafts what you tell him to. An all-in-one sythesizing solution.",
    "InternalName": "SomethingNeedDoing",
    "AssemblyVersion": "1.2.4.4",
    "RepoUrl": "https://github.com/daemitus/SomethingNeedDoing",
    "ApplicableVersion": "any",
    "DalamudApiLevel": 6,
    "LoadPriority": 0,
    "IconUrl": "https://github.com/daemitus/SomethingNeedDoing/raw/master/res/icon.png",
    "ImageUrls": [],
    "DownloadLinkInstall": "https://github.com/daemitus/MyDalamudPlugins/raw/master/plugins/SomethingNeedDoing/latest.zip",
    "IsHide": false,
    "IsTestingExclusive": false,
    "DownloadLinkTesting": "https://github.com/daemitus/MyDalamudPlugins/raw/master/plugins/SomethingNeedDoing/latest.zip",
    "DownloadLinkUpdate": "https://github.com/daemitus/MyDalamudPlugins/raw/master/plugins/SomethingNeedDoing/latest.zip",
    "DownloadCount": 0,
    "LastUpdate": "1652502386"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants