Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(generate-changelogs): set dry_run to true by default #146

Merged
merged 1 commit into from
Jul 11, 2023
Merged

ci(generate-changelogs): set dry_run to true by default #146

merged 1 commit into from
Jul 11, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jul 10, 2023 •
edited
Loading

Background

Replicate PR - daeuniverse/dae#201

Prevent writing changelogs to GitHub issues by default.

Checklist

Full changelog

  • ci(generate-changelogs): set dry_run to true by default

Issue reference

NA

Test Result

https://github.com/daeuniverse/dae-1/actions/runs/5508370825

@piyoki piyoki requested a review from a team as a code owner July 10, 2023 11:59
dae-prow[bot]
dae-prow bot approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki piyoki merged commit 105fd30 into main Jul 11, 2023
@piyoki piyoki deleted the dry_run branch July 11, 2023 07:23
@piyoki piyoki mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

Assignees

@piyoki piyoki

Labels
ci tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@piyoki