Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(prerelease): include v*.*.*rc* (v0.1.1rc1) case #75

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jun 19, 2023

Background

As the title suggests - include (e.g. v0.1.1rc1) case

Checklist

Full changelog

  • ci(prerelease): catch v*.*.rc (v0.1.1rc1) case

Test Results

before

image image

After

image image image

Issue reference

NA

@piyoki piyoki requested a review from a team as a code owner June 19, 2023 13:00
@dae-prow dae-prow bot added the ci label Jun 19, 2023
@piyoki piyoki requested review from kunish and MarksonHon June 19, 2023 13:01
@kunish
Copy link
Member

kunish commented Jun 19, 2023

Seems legit enough, but any test results?

@piyoki
Copy link
Contributor Author

piyoki commented Jun 19, 2023

@kunish let me have a try.

@piyoki
Copy link
Contributor Author

piyoki commented Jun 19, 2023

Seems legit enough, but any test results?

Updated test result in PR description.

@kunish kunish merged commit e5ee50e into main Jun 19, 2023
@kunish kunish deleted the prerelease-trigger-fix branch June 19, 2023 13:17
@kunish
Copy link
Member

kunish commented Jun 19, 2023

Sorry for the inconvenience and thank you for the contribution, I need to do more like you do in this PR in the future, tests, detailed descriptions and screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants