Allowing user to supply paths for jquery and can. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables can-compile to work offline if the paths local. The new resolveScripts utility uses a version mapping to determine the correct version of jQuery and what view engines to include for a given version of CanJS.
| @@ -38,7 +40,7 @@ module.exports = function(files, configuration, callback, log) { | |||
| } | |||
| var list = results.map(function(compiled) { | |||
| var options = compiled[1]; | |||
| var method = configuration.version.indexOf('2.1') === 0 ? 'preloadStringRenderer' : 'preload'; | |||
| var method = semver.satisfies(configuration.version, '>=2.1.x') ? 'preloadStringRenderer' : 'preload'; | |||
There was a problem hiding this comment.
👍 I just realized that the old one would break with 2.2
daffl
added a commit
that referenced
this pull request
Apr 13, 2015
Allowing user to supply paths for jquery and can.
|
I think this will solve #35, too. |
This was referenced Apr 13, 2015
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables can-compile to work offline if the paths are local.
The new resolveScripts utility determines the correct version of jQuery and what view engines to include for a given version of CanJS.
This still needs tests. The PR is mostly to see the proposed changes as a diff and solicit feedback.