Fix: Highlight "inconclusive" as errors in the gutter icons #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3821
Now, the screenshot is strictly better than before (assertions that are inconclusive are highlighted as errors in the gutter)
However, there is one problem remaining:
Indeed, inconclusiveness happens for an entire batch, and its token is determined by Boogie to be the method's name no matter what. This is why in the screenshot "Test" is underlined in red (that's the diagnostic token), whereas the gutter icons are chosen based on the individual assertion's tokens.
We should change this at the boogie level, but for now this PR is an improvement over the existing state of the art.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.