Include both locations in duplicate module name error messages #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
commented
Sep 1, 2023
| @@ -221,7 +221,7 @@ public class ProjectManager : IDisposable { | |||
| return await CompilationManager.LastDocument; | |||
| } | |||
|
|
|||
| public async Task<IdeState> GetSnapshotAfterParsingAsync() { | |||
There was a problem hiding this comment.
Changes in this file are an unrelated tiny refactoring
stefan-aws
approved these changes
Sep 1, 2023
keyboardDrummer
added a commit
to keyboardDrummer/dafny
that referenced
this pull request
Sep 15, 2023
…-lang#4499) Fixes dafny-lang#4289 <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 15, 2023
Fixes #4289 <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
Fixes #4289 <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
Fixes #4289 <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4289
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.