Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset object payload to null #13

Closed
wants to merge 1 commit into from

Conversation

ro-ka
Copy link

@ro-ka ro-ka commented Jul 27, 2016

Fixes #12.

@dafortune
Copy link
Owner

dafortune commented Jul 30, 2016

Hi @ro-ka thanks for your PR. Unfortunatelly part of this plugin goal is to bring back the same behavior qs feature used to have on Hapi<=11, I've just tested it and did see that current behavior is the one expected on hapi@11, so I don't think that changing the default behavior is good in this case.

Let me investigate the issue regarding what you pointed out (probably tomorrow) and if there is a good use case for it we might want to add this as an opt-in feature instead of a default one.

@ro-ka
Copy link
Author

ro-ka commented Aug 1, 2016

As noted in #12, I found a workaround for my problem. Will close this PR as there might be a better solution than the one I provided as a quick fix without deeper knowledge of the Hapi origins.

@ro-ka ro-ka closed this Aug 1, 2016
@ro-ka ro-ka deleted the fix/empty-object-payload branch August 1, 2016 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants