feat: parse payload on multipart/form-data request #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! Great update! Could you add a quick test for this improvement? I have very little time this week. Otherwise I could probably do next week and merge If you want, you can use https://github.com/daf-spr/hapi-qs/blob/master/tests/features/parse-payload.test.js as reference. Thanks! |
|
Hi @daf-spr, I changed the test you mentioned to test against both form data types. |
| }) | ||
| }; | ||
| if (isMultipart) { | ||
| requestOptions.formData = form |
|
Great! Thanks, just a minor detail (a couple of missing semicolons) and it is good to go. |
jo
force-pushed
the
parse-payload-on-multipart-form-data-requests
branch
from
6dc22a0
to
58ee9f3
Compare
|
I added the two missing semicolons. It would be great to include a linter which runs as part of the test. I recommend standard. |
|
Great! Thanks. Will create a separate issue to add a linter. |
dafortune
added a commit
that referenced
this pull request
Feb 2, 2016
…orm-data-requests feat: parse payload on multipart/form-data request
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7