v2 refs #6187
Closed
v2 refs #6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Suraci <alex@dagger.io>
* Conn allows you to stub out query responses * Connect just exports the connect func from core/integration/, which now calls it (not worth making all the tests slightly more verbose) Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
* these are all client helpers that can be useful to others anyway * exposing a footest package is a common convention found in stdlib (e.g. net/http/httptest) * allows it to reference internal EngineConn interface Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
not really seeing a way this expands the attack vector Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
vito
force-pushed
the
refs-v2
branch
2 times, most recently
from
fda8850
to
cfca94c
Compare
* mod:// is now dv:// as it felt wrong to have the URI coupled to the object on the other end rather than purely the routing scheme. * refs which default to `github.com` no longer need a leading `//`, which is now used to detect when an alternative host is set * rename has to digest for consistency with elsewhere (e.g. Docker image refs) * move https:// and oci:// to a later section * reference the idea of having 'container.from' use a ref Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an RFC for v2 refs and implements it along the way.
TODO:
--nativedefault snuck in heregit { tags }mod://and/orgh://as proposed (modulo feedback)fixes DEV-3030